The implementation relies on a statefull service. This should be avoided.
If we need dumping some context, it should be added to the Data object to me.
Then, dumpers could read it and do things appropriately.
See also SourceContextProvider which has more intensive logic for extracting the stack trace.

@nicolas-grekas Thank you for the feed back. I've changed the implementation.

Do you have an idea on how can i insulate this new feature and set her only for CliDumper?

Because currently, without forcing file and line to null in getDump method of VarDumperTestTrait it has impact on all other tests and so maybe on functionnalities.

@ktherage can we move forward on this ;) ?

@Simperfit I'm stuck on unit tests. I this they are to much nested each other. Testing cli dumper makes HtmlDumper, ServerDumper and all the caster crashed.

@Simperfit @nicolas-grekas, I did some work on that, tests are finally green.
Could you, please, take a sometime to check those changes?

@nicolas-grekas I've applied your recommendations (hoping i've not misread them).
Can you review those changes please ?

I push-forced on your fork to rebase+target 4.4, and do some changes.
Can you please try if that works for you?
Also, I think this doesn't work when dump is called from inside console commands.
Can you also check that?

I push-forced on your fork to rebase+target 4.4, and do some changes.
Can you please try if that works for you?
Also, I think this doesn't work when dump is called from inside console commands.
Can you also check that?

@nicolas-grekas i've adapter unit test according to your changes and i've added one test for console command. Can you check them and tell me if they are good for you?

As we talked together, i've adapted tests to a smaller sample an removed the fix i made on CliDumper for tests.

I've also tried to call dump in a command of a website-skeleton and, as you pre-minded it, it does not worked but i don't know why (see the GIF bellow).

@ktherage the reason is that we wire a service as a dumper. Look for cli_dumper/html_dumper I think in the code base

@ktherage the reason is that we wire a service as a dumper. Look for cli_dumper/html_dumper I think in the code base

@nicolas-grekas Yes, here it is.
Do you mean that i shall add a service definition like that one below :

        <service id="var_dumper.contextualized_cli_dumper" class="Symfony\Component\VarDumper\Dumper\ContextualizedDumper">
            <argument type="service" id="var_dumper.cli_dumper" />
            <argument type="collection">
                <argument type="service" key="source">
                    <service class="Symfony\Component\VarDumper\Dumper\ContextProvider\SourceContextProvider">
                        <argument>%kernel.charset%</argument>
                        <argument type="string">%kernel.project_dir%</argument>
                        <argument type="service" id="debug.file_link_formatter" on-invalid="null" />
                    </service>
                </argument>
            </argument>
        </service>

and use this new service in the debug bundle in place of the var_dumper.cli_dumper service ?

@nicolas-grekas I've worked on that and fixed the error for commands (see bellow).

I also tried to fix the tests. But for me the CI behave strangely (depending on the php version).

Thank you @ktherage.

It doesn't work this way in browser.