[FrameworkBundle] Allow dots in translation domains #31451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a new feature to me, it should target master. |
Simperfit
reviewed
May 12, 2019
Simperfit
suggested changes
May 12, 2019
|
Changed target branch to master and added unit tests. |
|
this should indeed target master, as it will require the same kind of changes in any other code dealing with the same convention for translation resources (this will affect https://github.com/willdurand/BazingaJsTranslationBundle for instance). So we should not merge this as a bugfix. |
1693d99 to
1efd287
Compare
|
Is there anything else I need to do in order to get this PR merged? :-) |
Simperfit
approved these changes
Jun 9, 2019
fabpot
approved these changes
Jun 11, 2019
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Jun 11, 2019
…schaedl) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Allow dots in translation domains | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31400 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | tbd. <!-- required for new features --> ### Description With this fix it is now possible to have `.` in translation domains like `app.security.en.yaml`. ### Todo - [x] add a test case Commits ------- 4b593b0 [FrameworkBundle] Allow dots in translation domains
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this fix it is now possible to have
.in translation domains likeapp.security.en.yaml.Todo