[FrameworkBundle] Add cache configuration for PropertyInfo #31452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usually, we don't accept performance improvements (even huge ones like this) as bug fixes. Maybe could it be included in the next 4.3 beta (it's already late, but it's a huge improvement ; ping @symfony/deciders), but definitely not in 4.2. It looks like a introduced this class a while ago... and forgot to open the follow up PR with the FrameworkBundle wiring 😕. Thanks for finding this. |
dunglas
reviewed
May 10, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
|
The test failures seem unrelated. |
c04e598 to
7290c4a
Compare
|
Rebased for 4.3. |
|
Should I take account of @dunglas's comment:
And do the same for |
|
Yes please. |
e685d6f to
05bb11c
Compare
|
Changes done. |
dunglas
approved these changes
May 11, 2019
maxhelias
approved these changes
May 13, 2019
fabpot
approved these changes
May 13, 2019
05bb11c to
17f6225
Compare
|
Thank you @alanpoulain. |
fabpot
added a commit
that referenced
this pull request
May 13, 2019
…Info (alanpoulain) This PR was squashed before being merged into the 4.3 branch (closes #31452). Discussion ---------- [FrameworkBundle] Add cache configuration for PropertyInfo | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The PropertyInfoExtractor was not cached by default but the class to do it was surprisingly here, unused. I've added the configuration to enable it by default when it's not the development environment. I haven't added the warmup part because there are too much arguments for the methods (class, property, context). It will be a big boost for the performance! For this code: ```php $book = $this->serializer->deserialize('{"id":3,"reviews":[{"id": 7, "body": "This book is fantastic!", "rating": 9, "letter": "A", "publicationDate": "2019"}],"isbn":"978-0-5533-9243-2","title":"Fool\'s Assassin","description":"A famous saga","author":"Robin Hobb","publicationDate":"2014"}', Book::class, 'json'); $this->serializer->serialize($book, 'json'); ``` We obtain this:  The Blackfire comparison is here: https://blackfire.io/profiles/compare/2c746d26-320a-4aab-80ef-7276c2e92b96/graph Commits ------- 17f6225 [FrameworkBundle] Add cache configuration for PropertyInfo
Merged
This was referenced Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PropertyInfoExtractor was not cached by default but the class to do it was surprisingly here, unused.
I've added the configuration to enable it by default when it's not the development environment.
I haven't added the warmup part because there are too much arguments for the methods (class, property, context).
It will be a big boost for the performance! For this code:
We obtain this:
The Blackfire comparison is here: https://blackfire.io/profiles/compare/2c746d26-320a-4aab-80ef-7276c2e92b96/graph