[FrameworkBundle] Inform the user when save_path will be ignored #31620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't added tests yet because I'm not 100% sure what the best way to solve this was. This at least informs the user. However if it were possible to detect this and somehow have ini_set('session.save_path', $save_path); called that would fix the 'bug' but where to put that is a bit of a mystery. I also expect it may be useful to update the documentation related to this setting to explain why which I'd be happy to do if this was deemed the correct solution. |
weaverryan
reviewed
Jun 17, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
01f5e22 to
267a4f7
Compare
fabpot
approved these changes
Jul 8, 2019
fabpot
requested changes
Jul 8, 2019
| @@ -474,6 +475,12 @@ public function testNullSessionHandler() | |||
| $this->assertNull($container->getDefinition('session.storage.php_bridge')->getArgument(0)); | |||
| } | |||
|
|
|||
| public function testNullSessionHandlerWithSavePath() | |||
| { | |||
| $this->expectException(InvalidConfigurationException::class); | |||
There was a problem hiding this comment.
Must be converted to an annotation for tests to pass on old PHP versions.
267a4f7 to
a090129
Compare
|
Thank you @gnat42. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…gnored (gnat42) This PR was squashed before being merged into the 3.4 branch (closes #31620). Discussion ---------- [FrameworkBundle] Inform the user when save_path will be ignored | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no / maybe?? | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31611 | License | MIT When a project is created, framework.yaml or config.yml has handler_id set to ~. This uses the native php SessionHandler object which is instantiated with the save_path setting from php.ini or php-fpm.d/www.conf. If you set a save_path, it is silently ignored. When using mod_php for apache or php-fpm running as apache/nginx this is typically not a big deal (except your session files are stored someplace other than you actually wanted). However if using php-fpm and running as a non-standard user for the distro, it will fail silently. Sessions won't be saved because the setting has no effect. This throws a warning in those cases to inform the user. _It could be a BC because it changes the default configuration however fixes a 'long standing bug' if you will. Not sure what you want to do about that part._ Commits ------- a090129 [FrameworkBundle] Inform the user when save_path will be ignored
|
thank you! @fabpot |
This was referenced Jul 27, 2019
Merged
Merged
Merged
luispabon
added a commit
to luispabon/symfony
that referenced
this pull request
Aug 13, 2019
… notice instead
nicolas-grekas
added a commit
that referenced
this pull request
Aug 22, 2019
* 3.4: Revert "bug #31620 [FrameworkBundle] Inform the user when save_path will be ignored (gnat42)" [Form][PropertyPathMapper] Avoid extra call to get config
nicolas-grekas
added a commit
that referenced
this pull request
Aug 22, 2019
* 4.3: Revert "bug #31620 [FrameworkBundle] Inform the user when save_path will be ignored (gnat42)" [Form][PropertyPathMapper] Avoid extra call to get config [HttpKernel] remove unused fixtures
nicolas-grekas
added a commit
that referenced
this pull request
Aug 22, 2019
* 4.4: Revert "bug #31620 [FrameworkBundle] Inform the user when save_path will be ignored (gnat42)" [Form][PropertyPathMapper] Avoid extra call to get config [HttpKernel] remove unused fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a project is created, framework.yaml or config.yml has handler_id set to ~. This uses the native php SessionHandler object which is instantiated with the save_path setting from php.ini or php-fpm.d/www.conf. If you set a save_path, it is silently ignored. When using mod_php for apache or php-fpm running as apache/nginx this is typically not a big deal (except your session files are stored someplace other than you actually wanted). However if using php-fpm and running as a non-standard user for the distro, it will fail silently. Sessions won't be saved because the setting has no effect. This throws a warning in those cases to inform the user.
It could be a BC because it changes the default configuration however fixes a 'long standing bug' if you will. Not sure what you want to do about that part.