Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Remove deprecated implementation of ChoiceLoaderInterface in intl forms #31665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented May 28, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

See previous PR #26825 (4.1)

@yceruto
Copy link
Member Author

yceruto commented May 28, 2019

Status: Needs Work

@yceruto yceruto force-pushed the rm_intl_form_type_deprecation branch 2 times, most recently from bbe40d5 to 08307c3 Compare May 28, 2019 20:26
@yceruto
Copy link
Member Author

yceruto commented May 28, 2019

(Tests failures unrelated)

Status: Needs Review

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the added static to a PR for 4.4

@yceruto yceruto force-pushed the rm_intl_form_type_deprecation branch from 08307c3 to b22cbf4 Compare May 29, 2019 11:24
@nicolas-grekas
Copy link
Member

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit b22cbf4 into symfony:master May 29, 2019
nicolas-grekas added a commit that referenced this pull request May 29, 2019
…nterface in intl forms (yceruto)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Remove deprecated implementation of ChoiceLoaderInterface in intl forms

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See previous PR #26825 (4.1)

Commits
-------

b22cbf4 Remove deprecated implementation of ChoiceLoaderInterface in intl forms
@yceruto yceruto deleted the rm_intl_form_type_deprecation branch May 29, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants