[Config] Removed env var support with cannotBeEmpty() #31678
Conversation
|
A test case is failing. |
| @@ -22,7 +22,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "symfony/yaml": "^4.4|^5.0", | |||
| "symfony/config": "^4.4|^5.0", | |||
| "symfony/config": "^5.0", | |||
There was a problem hiding this comment.
Is there a way not doing this? We'd better resist these when possible.
There was a problem hiding this comment.
not sure how to detect Config 5.0 :/
then again .. it's nice to enforce the same behavior for everyone on DI 5.0 no?
There was a problem hiding this comment.
I would try to try harder here: shouldn't the test case be moved to the config component?
This doesn't look legit to me.
There was a problem hiding this comment.
updated
shouldn't the test case be moved to the config component?
i favored a di+config integration test, instead of a config unit test. Integration test have to deal with low/high deps either way. It now covers the deps=high case, assuming the legacy test is covered on lower branches still.
There was a problem hiding this comment.
agree 4.4|5.0 is the better constraint, which is conceptually the same behavior already but allows users to opt for deprecations vs. exceptions basically.
|
Thank you @ro0NL. |
…o0NL) This PR was merged into the 5.0-dev branch. Discussion ---------- [Config] Removed env var support with cannotBeEmpty() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> See #28858 Commits ------- ec27d74 [Config] Removed env var support with cannotBeEmpty()
See #28858