Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Remove DateTime support in date/time validators #31679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2019
Merged

[Validator] Remove DateTime support in date/time validators #31679

merged 1 commit into from
May 29, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented May 29, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

See #25015

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone May 29, 2019
@nicolas-grekas
Copy link
Member

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit 37c1cbb into symfony:master May 29, 2019
nicolas-grekas added a commit that referenced this pull request May 29, 2019
@nicolas-grekas
minor #31679 [Validator] Remove DateTime support in date/time validat…
a052378 
…ors (ro0NL)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Validator] Remove DateTime support in date/time validators

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

See #25015

Commits
-------

37c1cbb [Validator] Remove DateTime support in date/time validators
@ro0NL ro0NL deleted the validator branch May 29, 2019 09:40
@sacarr sacarr mentioned this pull request Jun 15, 2020
Closed
pbek pushed a commit to digital-blueprint/relay-checkin-bundle that referenced this pull request Feb 1, 2023
@lazka
Fix a symfony5 regression which made guest checkins fail
9a7243a 
@Assert\DateTime no longer accepts DateTime objects, but only strings
in Symfony 5. Instead check the real type.

See symfony/symfony#31679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ro0NL @nicolas-grekas @carsonbot