Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Remove CsvEncoder "as_collection" deprecation & change default value #31684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2019
Merged

[Serializer] Remove CsvEncoder "as_collection" deprecation & change default value #31684

merged 1 commit into from
May 29, 2019

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented May 29, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes (AppVeyor failure unrelated. See https://github.com/symfony/symfony/pull/31685/files)
Fixed tickets #27715
License MIT
Doc PR N/A

As planned in #27715

@chalasr chalasr added this to the 5.0 milestone May 29, 2019
@ogizanagi ogizanagi requested a review from dunglas as a code owner May 29, 2019 14:15
@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 22dd071 into symfony:master May 29, 2019
nicolas-grekas added a commit that referenced this pull request May 29, 2019
…on & change default value (ogizanagi)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Serializer] Remove CsvEncoder "as_collection" deprecation & change default value

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes  (AppVeyor failure unrelated. See https://github.com/symfony/symfony/pull/31685/files)  <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27715   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

As planned in #27715

Commits
-------

22dd071 [Serializer] Remove CsvEncoder "as_collection" deprecation & change default value
@ogizanagi ogizanagi deleted the rm_deprec/serializer/csv_collection branch May 29, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants