[TwigBridge] Swapped $rootDir and $fileLinkFormatter arguments in DebugCommand #31688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
reviewed
May 29, 2019
f917608 to
eb46a30
Compare
eb46a30 to
200441e
Compare
|
@nicolas-grekas comments addressed, thanks! |
200441e to
beca864
Compare
nicolas-grekas
approved these changes
May 29, 2019
Tobion
approved these changes
May 29, 2019
|
Thank you @yceruto. |
Tobion
added a commit
that referenced
this pull request
May 29, 2019
…uments in DebugCommand (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [TwigBridge] Swapped $rootDir and $fileLinkFormatter arguments in DebugCommand | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is necessary to remove the `$rootDir` in 5.0, see #31667 Commits ------- beca864 exchanged $rootDir and $fileLinkFormatter arguments in DebugCommand
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [TwigBundle] bump Twig bridge dependency | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31688 | License | MIT | Doc PR | We need a version of the `DebugCommand` class that is compatible with its service definition in the Twig bundle. Commits ------- 9df66b8 bump Twig bridge dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to remove the
$rootDirin 5.0, see #31667