Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Marked several components as incompatible with EventDispatcher 5 #31712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented May 29, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Quite a few components still use the old event class that is to be removed in Symfony 5. This PR ensures that they are only installed with EventDispatcher 4.

Follow up to #31709

@derrabus derrabus requested review from lyrixx and xabbuh as code owners May 29, 2019 22:45
@chalasr chalasr requested a review from nicolas-grekas May 29, 2019 23:28
@chalasr chalasr added this to the next milestone May 29, 2019
@derrabus derrabus force-pushed the improvement/event-dispatcher-compat branch from 11cac9e to e6a4526 Compare May 30, 2019 07:48
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit e6a4526 into symfony:4.4 May 30, 2019
nicolas-grekas added a commit that referenced this pull request May 30, 2019
…atcher 5 (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

Marked several components as incompatible with EventDispatcher 5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Quite a few components still use the old event class that is to be removed in Symfony 5. This PR ensures that they are only installed with EventDispatcher 4.

Follow up to #31709

Commits
-------

e6a4526 Marked several components as incompatible with EventDispatcher 5.
@derrabus derrabus deleted the improvement/event-dispatcher-compat branch May 30, 2019 10:00
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants