Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client #31719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
May 30, 2019
nicolas-grekas
requested changes
May 30, 2019
nicolas-grekas
approved these changes
May 30, 2019
|
Thank you @andrew-demb. |
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
…Test\WebTestCase::$client (andrew-demb) This PR was squashed before being merged into the 4.3 branch (closes #31719). Discussion ---------- Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> In `Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client` property exists phpdoc about property class, but no `use` declaration added. As `Symfony\Bundle\FrameworkBundle\Client` deprecated, and actually this will be `Symfony\Bundle\FrameworkBundle\KernelBrowser` instance, we can put `KernelBrowser` instead `Client` (not sure about BC) <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 6982025 Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$clientproperty exists phpdoc about property class, but nousedeclaration added.As
Symfony\Bundle\FrameworkBundle\Clientdeprecated, and actually this will beSymfony\Bundle\FrameworkBundle\KernelBrowserinstance, we can putKernelBrowserinsteadClient(not sure about BC)