[HttpKernel] Don't install HttpKernel 4.4 with Console 5 #31734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
May 30, 2019
|
Would it make more sense to do this on the console component? Reading your description, that's what I was expecting. |
|
Hum ok, no, console doesn't know about http-kernel. |
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
… (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Don't install HttpKernel 4.4 with Console 5 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Another attempt to get the build of #31709 green. Because the base class of `ConsoleEvent` was changed, the Console component 5.0 in going to be incompatible with `DebugHandlersListener` in HttpKernel 4.4. Commits ------- 44f326d HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to get the build of #31709 green. Because the base class of
ConsoleEventwas changed, the Console component 5.0 in going to be incompatible withDebugHandlersListenerin HttpKernel 4.4.