[FrameworkBundle] Add missing BC layer for deprecated ControllerNameParser injections #31739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2466e1d to
aee1887
Compare
|
Fabbot failure is a false positive. |
src/Symfony/Bundle/FrameworkBundle/Controller/ControllerResolver.php
Outdated
Show resolved
Hide resolved
83f02cd to
cc3cc48
Compare
derrabus
requested changes
May 30, 2019
src/Symfony/Bundle/FrameworkBundle/Controller/ControllerResolver.php
Outdated
Show resolved
Hide resolved
|
Thanks @chalasr ! |
|
Status: Needs review |
src/Symfony/Bundle/FrameworkBundle/Controller/ControllerNameParser.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Controller/ControllerResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php
Outdated
Show resolved
Hide resolved
c435c45 to
a00eb63
Compare
|
Thanks for the review, comments addressed |
Tobion
reviewed
May 31, 2019
Tobion
reviewed
May 31, 2019
e7ac670 to
fac9377
Compare
8d029ce to
5bf0fcd
Compare
src/Symfony/Bundle/FrameworkBundle/EventListener/ResolveControllerNameSubscriber.php
Outdated
Show resolved
Hide resolved
5bf0fcd to
b244cb8
Compare
src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml
Outdated
Show resolved
Hide resolved
e9e8e9c to
bdaf15d
Compare
bdaf15d to
1f37275
Compare
fabpot
approved these changes
Jun 4, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jun 4, 2019
…ControllerNameParser injections (chalasr) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Add missing BC layer for deprecated ControllerNameParser injections | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Allows removing the `ControllerNameParser` class and corresponding `controller_name_converter` service in 5.0. Should have been done in 4.1, better late than never. Commits ------- 1f37275 [FrameworkBundle] Add missing BC layer for deprecated ControllerNameParser injections
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows removing the
ControllerNameParserclass and correspondingcontroller_name_converterservice in 5.0.Should have been done in 4.1, better late than never.