[Serializer] Remove last deprecated/obsolete paths #31771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
commented
May 31, 2019
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
| if (class_exists(MimeTypes::class)) { | ||
| $mimeTypeGuesser = MimeTypes::getDefault(); | ||
| } else { | ||
| @trigger_error(sprintf('Passing null to "%s()" without symfony/mime installed is deprecated since Symfony 4.3, install symfony/mime.', __METHOD__), E_USER_DEPRECATED); |
There was a problem hiding this comment.
this should be an exception now?
There was a problem hiding this comment.
That's what I thought too (see second commit), but the data uri normalizer used to fallback to application/octet-stream if no default mime type guesser can be instantiated. So neither was the http-foundation nor the mime type component a strict dependency to use it.
There was a problem hiding this comment.
this notice is wrong in the first place and should be removed from 4.3 then, right?
There was a problem hiding this comment.
Indeed. See #31923
src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
Outdated
Show resolved
Hide resolved
Simperfit
approved these changes
Jun 1, 2019
chalasr
reviewed
Jun 1, 2019
| if (class_exists(MimeTypes::class)) { | ||
| $mimeTypeGuesser = MimeTypes::getDefault(); | ||
| } else { | ||
| @trigger_error(sprintf('Passing null to "%s()" without symfony/mime installed is deprecated since Symfony 4.3, install symfony/mime.', __METHOD__), E_USER_DEPRECATED); |
There was a problem hiding this comment.
this notice is wrong in the first place and should be removed from 4.3 then, right?
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
| * @param object $object | ||
| * @param string|null $format | ||
| * @param array $context | ||
| * @param object $object |
There was a problem hiding this comment.
we can add the type and remove the annotation actually - PHP7.2 allows it
| */ | ||
| protected function createChildContext(array $parentContext, $attribute/*, ?string $format */) | ||
| protected function createChildContext(array $parentContext, string $attribute, ?string $format): array |
There was a problem hiding this comment.
should have null as default, otherwise that's a hard BC break
There was a problem hiding this comment.
The method is internal. That should be fine, right?
There was a problem hiding this comment.
@internal is not transitive
once all are correctly annotated on 4.4, sure :)
nicolas-grekas
added a commit
that referenced
this pull request
Jun 7, 2019
…guesser is optional) (ogizanagi) This PR was merged into the 4.3 branch. Discussion ---------- [Serializer] Fix DataUriNormalizer deprecation (MIME type guesser is optional) | Q | A | ------------- | --- | Branch? | 4.3 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Relates to #31771 (comment) : The deprecation isn't fundamentally wrong, but if none of the Mime nor HttpFoundation components are installed, the DataUriNormalizer can be used, and the MIME type used will always be `'application/octet-stream'` https://github.com/symfony/symfony/blob/9691519ca46511005bc701ca93c2973923952034/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php#L39-L46 https://github.com/symfony/symfony/blob/9691519ca46511005bc701ca93c2973923952034/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php#L135-L139 So this completes the deprecation message, as well as allowing `null` again when no default MIME type guesser is available at all. Commits ------- 2740bd1 [Serializer] Fix DataUriNormalizer deprecation (MIME type guesser is optional)
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2019
…anagi) This PR was merged into the 5.0-dev branch. Discussion ---------- [Serializer] Remove last deprecated/obsolete paths | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28316, #28709, #31030, #27020, #29896, 16f8a13#r201060750 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> This should fix the last deprecations & obsolete code paths for the Serializer component. Commits ------- c703b35 [Serializer] Remove last deprecated/obsolete paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the last deprecations & obsolete code paths for the Serializer component.