[PropertyInfo] Extract property type from property declaration #31798

tsantos84 · 2019-06-02T19:56:30Z

Q	A
Branch?	4.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	-
Fixed tickets	-
License	MIT
Doc PR	-

The next minor version of PHP (7.4) will introduce the feature Typed Property where it'll be possible to declare strong type for class properties. With this nice addition, PropertyInfo component is able to extract property type from the property declaration.

class Dummy {
     public int $int;
     public ?string $string;
}

$types = $propertyInfo->getTypes('Dummy', 'int');

/*
  Example Result
  --------------
  array(1) {
    [0] =>
    class Symfony\Component\PropertyInfo\Type (6) {
      private $builtinType          => string(3) "int"
      private $nullable             => bool(false)
      private $class                => null
      private $collection           => bool(false)
      private $collectionKeyType    => NULL
      private $collectionValueType  => NULL
    }
  }
*/

$types = $propertyInfo->getTypes('Dummy', 'string');

/*
  Example Result
  --------------
  array(1) {
    [0] =>
    class Symfony\Component\PropertyInfo\Type (6) {
      private $builtinType          => string(3) "string"
      private $nullable             => bool(true)
      private $class                => null
      private $collection           => bool(false)
      private $collectionKeyType    => NULL
      private $collectionValueType  => NULL
    }
  }
*/

Technical Notes

Property type declaration extraction should precede any other kind of extraction as it is the most reliable source of reflection metadata.
The unit tests for this PR will run only when PHP 7.4+ is installed and will be skipped otherwise. The .travisci file was changed to add the required PHP version. The 7.4-dev version (aliased as 7.4snapshot) was configured in travis until the stable release is launch.

mshavliuk · 2019-06-06T19:31:54Z

src/Symfony/Component/PropertyInfo/Tests/Fixtures/Php74Dummy.php

+    public int $int;
+    public ?string $string;
+    public Dummy $dummy;
+    public ?Dummy $optionalDummy;


It looks like you forgot about "callable" property, which is mention in test

Actually, this test case should be removed because declaring callable for a property is not allowed. https://wiki.php.net/rfc/typed_properties_v2

mshavliuk · 2019-06-07T07:34:15Z

src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

+        if ($fromDeclaredType = $this->extractFromDeclaredType($class, $property)) {
+            return $fromDeclaredType;
+        }
+


This change causing test fails:

PHPUnit 7.4.5 by Sebastian Bergmann and contributors. Testing Symfony Property Info Component Test Suite ............................................................... 63 / 188 ( 33%) .....SSS.................................EEEEEEEEEEEEEEEEEEEEEE 126 / 188 ( 67%) .............................................................. 188 / 188 (100%) Time: 7.72 seconds, Memory: 8.00 MB There were 22 errors: 1) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #0 ('a', null) ReflectionException: Property a does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 2) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #1 ('b', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property b does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 3) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #2 ('c', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property c does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 4) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #3 ('d', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property d does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 5) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #4 ('e', null) ReflectionException: Property e does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 6) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #5 ('f', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property f does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 7) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #6 ('donotexist', null) ReflectionException: Property donotexist does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 8) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #7 ('staticGetter', null) ReflectionException: Property staticGetter does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 9) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #8 ('staticSetter', null) ReflectionException: Property staticSetter does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 10) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #9 ('self', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property self does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 11) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractors with data set #10 ('realParent', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property realParent does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:155 12) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp7Type with data set #0 ('foo', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property foo does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:180 13) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp7Type with data set #1 ('bar', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property bar does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:180 14) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp7Type with data set #2 ('baz', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property baz does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:180 15) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp7Type with data set #3 ('buz', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property buz does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:180 16) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp7Type with data set #4 ('biz', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property biz does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:180 17) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp7Type with data set #5 ('donotexist', null) ReflectionException: Property donotexist does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:180 18) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp71Type with data set #0 ('foo', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property foo does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:200 19) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp71Type with data set #1 ('buz', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property buz does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:200 20) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp71Type with data set #2 ('bar', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property bar does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:200 21) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp71Type with data set #3 ('baz', array(Symfony\Component\PropertyInfo\Type Object (...))) ReflectionException: Property baz does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:200 22) Symfony\Component\PropertyInfo\Tests\Extractor\ReflectionExtractorTest::testExtractPhp71Type with data set #4 ('donotexist', null) ReflectionException: Property donotexist does not exist /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:205 /usr/src/app/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php:112 /usr/src/app/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php:200 ERRORS! Tests: 188, Assertions: 251, Errors: 22, Skipped: 3.

You can easily reproduce this tests by running this in src/Symfony/Component/PropertyInfo:

docker run --rm -it -v $(pwd):/var/www/html devilbox/php-fpm-7.4 bash composer install # (if you don't have yet) composer require --dev symfony/test-pack vendor/bin/simple-phpunit

mshavliuk · 2019-06-07T07:37:55Z

src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

+        } catch (\ReflectionException $e) {
+            return null;
+        }
+


To prevent test fails you can add following code here:

if (!$reflectionClass->hasProperty($property)) { return null; }

Or you can expand try-catch block for the whole function content (to prevent errors, which can happen while calling hasType, getProperty, getType etc. which can throw ReflectionException).
I think the best option - add either hasProperty or expand try-catch.

I've used the same try/catch block where I create the reflection class to get the property, and if it doesn't exist, it'll return null

mshavliuk · 2019-06-07T09:03:54Z

src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

+        if ($fromDeclaredType = $this->extractFromDeclaredType($class, $property)) {
+            return $fromDeclaredType;
+        }
+


You can easily reproduce this tests by running this in src/Symfony/Component/PropertyInfo:

docker run --rm -it -v $(pwd):/var/www/html devilbox/php-fpm-7.4 bash composer install # (if you don't have yet) composer require --dev symfony/test-pack vendor/bin/simple-phpunit

tsantos84 · 2019-06-07T11:04:56Z

I'm wondering if this feature should allow failure for PHP 7.4-dev on travisci since the PHP7.4 is not officially released. What do you think?

stof · 2019-06-07T11:06:28Z

src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

+    private function extractFromDeclaredType(string $class, string $property)
+    {
+        // to be removed as soon as Symfony bumps the minimum PHP Version to 7.4
+        if (version_compare(PHP_VERSION, '7.4.0-dev', '<')) {


this should use \PHP_VERSION_ID < 70400 instead. This matches our conventions, which are set this way because it allows to have the condition resolved at compile-time (and so OPCache can optimize the code)

stof · 2019-06-07T11:07:17Z

src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

@@ -185,6 +189,30 @@ public function isInitializable(string $class, string $property, array $context
        return false;
    }

+    private function extractFromDeclaredType(string $class, string $property)
+    {
+        // to be removed as soon as Symfony bumps the minimum PHP Version to 7.4


this comment should be removed. Looking for any check on \PHP_VERSION_ID is part of our process to bump the min version, so it will be done. The comment would not be checked.

stof · 2019-06-07T11:11:05Z

src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

        }

        return $type;
    }

-    private function resolveTypeName(string $name, \ReflectionMethod $reflectionMethod): string
+    private function resolveTypeName(string $name, ?\ReflectionMethod $reflectionMethod, ?\ReflectionProperty $reflectionProperty): string


as we only need ->getDeclaringClass(), which is common on both class, I suggest using a single argument accepting \ReflectionMethod|\ReflectionProperty (and same in extractFromReflectionType). This will keep the code simpler

Better than contribute with something is learn something contributing.

Actually this doesn't seems to be a valid syntax. Is your suggestion something like this?

private function extractFromReflectionType(\ReflectionType $reflectionType, \ReflectionMethod|\ReflectionProperty $reflector): Type {...}

Or you are suggesting to not declare this argument with type:

/** * @param \ReflectionMethod|\ReflectionProperty $reflector */ private function extractFromReflectionType(\ReflectionType $reflectionType, object $reflector): Type {...}

both \ReflectionMethod and \ReflectionProperty implements Reflector interface, so you can declare it like this:

/** * @param \ReflectionMethod|\ReflectionProperty $reflector */ private function extractFromReflectionType(\ReflectionType $reflectionType, \Reflector $reflector): Type {...}

Yes, both implements \Reflector but \Reflector doesn't have the necessary getDeclaringClass() method. In this case, I don't think that we should use this interface as a typehint.

In any case It is far better than just object. For more specific typehint @param declaration will be enough.

As both extractFromReflectionType and resolveTypeName are private methods, I'm good to remove any typehint for this argument and declare its type on @param docblock. What do you think?

stof · 2019-06-07T11:12:38Z

src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

    {
+        if (null === ($reflection = $reflectionMethod ?? $reflectionProperty)) {


calling the variable $reflector would be better, as that's the naming used by PHP for its interface implemented by all reflection classes (but it does not make sense to use it as typehint, as getDeclaringClass is not part of this interface as other reflection classes don't implement it)

tsantos84 · 2019-06-08T23:08:43Z

Could someone point me about travis?

nicholasruunu · 2019-07-09T22:56:14Z

Could someone point me about travis?

apcu-5.1.16 is not compatible with php 7.4, it needs to install apcu-5.1.17

ro0NL · 2020-03-04T15:13:37Z

cc @dunglas can you have a look here :) this would fix all "Example values" in API platform for input DTOs, a rather annoying bug

i blindly replaced @var with type info, ony to discover this side effect. I prefer merging this PR asap rather than temporarily putting back @var info.

dunglas · 2020-03-04T16:35:37Z

A similar PR has already been merged in master: #34557

Closing this one.

tsantos84 added 3 commits June 2, 2019 16:22

[PropertyInfo] Extract type from property declaration

4baeb0c

[PropertyInfo] Add PHP 7.4-dev to travisci

e903eeb

[PropertyInfo] Change log note

e71852d

carsonbot added Status: Needs Review Feature labels Jun 2, 2019

[PropertyInfo] Change variable name

550c4d2

nicolas-grekas added this to the next milestone Jun 2, 2019

tsantos84 changed the title ~~Extract type from declaration~~ [PropertyInfo] Extract type from declaration Jun 2, 2019

tsantos84 changed the title ~~[PropertyInfo] Extract type from declaration~~ [PropertyInfo] Extract property type from declaration Jun 2, 2019

tsantos84 marked this pull request as ready for review June 2, 2019 20:13

tsantos84 requested a review from dunglas as a code owner June 2, 2019 20:13

tsantos84 changed the title ~~[PropertyInfo] Extract property type from declaration~~ [PropertyInfo] Extract property type from property declaration Jun 3, 2019

mshavliuk suggested changes Jun 6, 2019

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jun 6, 2019

tsantos84 added 3 commits June 6, 2019 22:24

[PropertyInfo] Remove callable from tests

afaea21

[PropertyInfo] Add copyright text

d11d8f0

[PropertyInfo] Add test case for iterable type

f2b5c1a

mshavliuk suggested changes Jun 7, 2019

View reviewed changes

tsantos84 added 3 commits June 7, 2019 07:51

[PropertyInfo] Add self and parent type

72ee401

[PropertyInfo] Prevent exception in case the property doesn't exist

2a273c1

[PropertyInfo] Fix code standard

4e5bfe1

stof reviewed Jun 7, 2019

View reviewed changes

tsantos84 added 3 commits June 7, 2019 09:34

[PropertyInfo] Fix PHP version comparison

2f8b2fe

[PropertyInfo] Unifying $reflector argument to keep code cleaner

7f1095d

[PropertyInfo] Fix code standard

92e8be6

[PropertyInfo] Remove typehint for $resolver argument

d6c3e5a

[PropertyInfo] Change exception

bc8d70c

dunglas closed this Mar 4, 2020

nicolas-grekas modified the milestones: next, 5.1 May 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PropertyInfo] Extract property type from property declaration #31798

[PropertyInfo] Extract property type from property declaration #31798

tsantos84 commented Jun 2, 2019 •

edited

Loading

mshavliuk Jun 6, 2019 •

edited

Loading

tsantos84 Jun 7, 2019

mshavliuk Jun 7, 2019

mshavliuk Jun 7, 2019 •

edited

Loading

tsantos84 Jun 7, 2019

mshavliuk Jun 7, 2019

mshavliuk Jun 7, 2019 •

edited

Loading

tsantos84 Jun 7, 2019

mshavliuk Jun 7, 2019 •

edited

Loading

tsantos84 commented Jun 7, 2019

stof Jun 7, 2019

stof Jun 7, 2019

stof Jun 7, 2019

tsantos84 Jun 7, 2019

tsantos84 Jun 7, 2019 •

edited

Loading

mshavliuk Jun 7, 2019 •

edited

Loading

tsantos84 Jun 7, 2019 •

edited

Loading

mshavliuk Jun 7, 2019

tsantos84 Jun 8, 2019

stof Jun 7, 2019

tsantos84 commented Jun 8, 2019

nicholasruunu commented Jul 9, 2019

ro0NL commented Mar 4, 2020 •

edited

Loading

dunglas commented Mar 4, 2020

		{
		if (null === ($reflection = $reflectionMethod ?? $reflectionProperty)) {

[PropertyInfo] Extract property type from property declaration #31798

[PropertyInfo] Extract property type from property declaration #31798

Conversation

tsantos84 commented Jun 2, 2019 • edited Loading

Technical Notes

mshavliuk Jun 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshavliuk Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshavliuk Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshavliuk Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

tsantos84 commented Jun 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsantos84 Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

mshavliuk Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

tsantos84 Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsantos84 commented Jun 8, 2019

nicholasruunu commented Jul 9, 2019

ro0NL commented Mar 4, 2020 • edited Loading

dunglas commented Mar 4, 2020

tsantos84 commented Jun 2, 2019 •

edited

Loading

mshavliuk Jun 6, 2019 •

edited

Loading

mshavliuk Jun 7, 2019 •

edited

Loading

mshavliuk Jun 7, 2019 •

edited

Loading

mshavliuk Jun 7, 2019 •

edited

Loading

tsantos84 Jun 7, 2019 •

edited

Loading

mshavliuk Jun 7, 2019 •

edited

Loading

tsantos84 Jun 7, 2019 •

edited

Loading

ro0NL commented Mar 4, 2020 •

edited

Loading