Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form][DX] Improved error message on create a form builder with invalid options #31827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

[Form][DX] Improved error message on create a form builder with invalid options #31827

merged 1 commit into from
Jun 4, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jun 3, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

before

The required option "class" is missing.

after

An error has occurred resolving the options of the form "App\Form\MyEntityType": The required option "class" is missing.

@yceruto yceruto requested a review from xabbuh as a code owner June 3, 2019 16:45
@carsonbot carsonbot added Status: Needs Review Form DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature labels Jun 3, 2019
@yceruto yceruto force-pushed the improve_error_message branch from 27cae8a to 21e35c7 Compare June 3, 2019 16:46
xabbuh
xabbuh reviewed Jun 3, 2019
View reviewed changes
@yceruto yceruto force-pushed the improve_error_message branch from 21e35c7 to 404a971 Compare June 3, 2019 16:57
@nicolas-grekas nicolas-grekas added this to the next milestone Jun 3, 2019
nicolas-grekas
nicolas-grekas reviewed Jun 3, 2019
View reviewed changes
@yceruto yceruto force-pushed the improve_error_message branch from 404a971 to 37c7a2b Compare June 3, 2019 19:24
@fabpot
Copy link
Member

fabpot commented Jun 4, 2019

Thank you @yceruto.

@fabpot fabpot merged commit 37c7a2b into symfony:4.4 Jun 4, 2019
fabpot added a commit that referenced this pull request Jun 4, 2019
@fabpot
minor #31827 [Form][DX] Improved error message on create a form build…
9ce3ff3 
…er with invalid options (yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[Form][DX] Improved error message on create a form builder with invalid options

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

**before**
> The required option "class" is missing.

**after**
> An error has occurred resolving the options of the form "App\Form\MyEntityType": The required option "class" is missing.

Commits
-------

37c7a2b Improved error message on create a form builder with invalid options
@yceruto yceruto deleted the improve_error_message branch June 14, 2019 13:26
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@yceruto @fabpot @nicolas-grekas @xabbuh @carsonbot