[Console] Add check for Konsole/Yakuake to disable hyperlinks #31849
Conversation
src/Symfony/Component/Console/Formatter/OutputFormatterStyle.php
Outdated
Show resolved
Hide resolved
|
Oh, please also patch VarDumper, it has a similar check. |
I'm on it. I've also noted that there was a test for TERMINAL_EMULATOR=JetBrains-JediTerm: should I add a test just for Konsole? And what should I do, just add another commit to the PR or I must close it and do another one with the two commits squashed? |
|
No tests is OK to me, this wouldn't make much sense. |
|
Opened bug report to Konsole: https://bugs.kde.org/show_bug.cgi?id=408288 |
There was a problem hiding this comment.
Thanks
For reference, this is a description of the feature for terminals:
https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
And I just discovered this gist contains a link to an existing Konsole issue:
https://bugs.kde.org/show_bug.cgi?id=379294
(but your issue is different: it's about degrading gracefully - not necessarily about supporting links)
|
Thank you @belinde. |
…nks (belinde) This PR was squashed before being merged into the 4.3 branch (closes #31849). Discussion ---------- [Console] Add check for Konsole/Yakuake to disable hyperlinks | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31809 | License | MIT | Doc PR | Added check for environment variable set by Konsole and other relateds terminal emulators. A ticket has been opened to Konsole team to support this feature someday: https://bugs.kde.org/show_bug.cgi?id=408288 Commits ------- 14b27b7 [Console] Add check for Konsole/Yakuake to disable hyperlinks
This PR was merged into the 4.4 branch. Discussion ---------- [Console] Re-enable hyperlinks in Konsole/Yakuake | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #31809 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Hyperlinks feature was broken in KDE's Konsole/Yakuake (#31809) and thus disabled by #31849. But the feature has been recently [implemented](https://invent.kde.org/utilities/konsole/-/merge_requests/138), and is about to be released in KDE 20.12 on December 10th 2020, see [release notes](https://community.kde.org/Releases/20.12_Release_Notes#Konsole).  Tested in RC version and seems to be working fine. The feature is disabled by default (as per security concerns), but even when disabled, it just gracefully don't show the links. Commits ------- 728edf3 [Console] Enable hyperlinks in Konsole/Yakuake
Added check for environment variable set by Konsole and other relateds terminal emulators.
A ticket has been opened to Konsole team to support this feature someday: https://bugs.kde.org/show_bug.cgi?id=408288