[Messenger] Add missing runtime check for ext redis version #31872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jun 5, 2019
|
Build failure is unrelated. |
stof
approved these changes
Jun 5, 2019
| @@ -43,6 +44,10 @@ class Connection | |||
|
|
|||
| public function __construct(array $configuration, array $connectionCredentials = [], array $redisOptions = [], \Redis $redis = null) | |||
There was a problem hiding this comment.
unrelated, but we missed making this class compatible with other kind of redis instances: RedisArray, RedisCluser, RedisProxy and RedisClusterProxy
There was a problem hiding this comment.
are they compatible with redis streams ?
There was a problem hiding this comment.
I think so, because in the end this is just a key. https://redis.io/topics/streams-intro also mentions clusters. But I didn't try, so maybe not. Yet the hardcoded signature would be a blocker for the future.
There was a problem hiding this comment.
I will give it a try and drop the typehint in favor of a check anyways.
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jun 5, 2019
…n (chalasr) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Add missing runtime check for ext redis version | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31791 | License | MIT | Doc PR | n/a Lower versions lead to segmentation faults. Commits ------- 07603da [Messenger] Add runtime check for ext redis version
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 13, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Redis 4.3 is required See symfony/symfony#31872 But also the conversation on symfony/messenger@47d2b91 So, I'm not actually sure if that commit is correct and the docs should be updated, or if that commit is wrong. Opening this up to at least have some placeholder to figure that out. Commits ------- c76afd3 Redis 4.3 is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower versions lead to segmentation faults.