[Doctrine Bridge] Check field type before adding Length constraint #31874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 5, 2019
src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Jun 5, 2019
src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Jun 6, 2019
|
Thank you @belinde. |
xabbuh
added a commit
that referenced
this pull request
Jun 6, 2019
…nstraint (belinde) This PR was squashed before being merged into the 4.3 branch (closes #31874). Discussion ---------- [Doctrine Bridge] Check field type before adding Length constraint | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31855 | License | MIT | Doc PR | Validator\DoctrineLoader now add a Length constraint only on field of type string, text and guid; for any other type the mapping length is just ignored Commits ------- 35e6df6 [Doctrine Bridge] Check field type before adding Length constraint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validator\DoctrineLoader now add a Length constraint only on field of type string, text and guid; for any other type the mapping length is just ignored