Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] fix from merge on ValidateEnvPlaceholdersPassTest #31940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Simperfit
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR

@xabbuh Even if it's not called this need to be fixed, but as speaking with @nicolas-grekas, we found out that there are something strange in here:

  • ConfigurationWithArrayNodeRequiringOneElement::getConfigTreeBuilder is never called
  • EnvExtension::load has an
if(!array_filter($config)) {return;}

and in the test using ConfigurationWithArrayNodeRequiringOneElement, the $config array is empty.
So maybe we have more to do in here than just fixing the merge. (we have the same issue with EnvConfigurationWithoutRootNode)

@nicolas-grekas
Copy link
Member

Thanks, replaced by #31942 (I fixed this while merging 4.4 into master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants