[DI][5.0] Fix suspicious test #31945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Jun 7, 2019
| /** | ||
| * @group legacy | ||
| */ | ||
| public function testConfigurationWithoutRootNode(): void |
There was a problem hiding this comment.
this cannot happen anymore with Config 5.0, in the #31678 the deps are updated .. as such i assumed we dont need this test anymore.
ro0NL
commented
Jun 7, 2019
| /** | ||
| * @author Roland Franssen <[email protected]> | ||
| */ | ||
| class TreeWithoutRootNodeException extends \RuntimeException |
There was a problem hiding this comment.
maybe we forgot to mark this @internal in 4.x ... 😅
nicolas-grekas
approved these changes
Jun 7, 2019
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [DI][5.0] Fix suspicious test | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Cleanup of #31944 for 5.0 Commits ------- 98c25dd [DI][5.0] Fix suspicious test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of #31944 for 5.0