[PhpunitBridge] Read environment variable from superglobals #31954

greg0ire · 2019-06-08T10:25:50Z

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#31857
License	MIT
Doc PR	n/a

The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

greg0ire · 2019-06-08T10:29:12Z

@nicolas-grekas should I do something similar here:

symfony/src/Symfony/Bridge/PhpUnit/bootstrap.php

Lines 38 to 40 in 1dce522

    
           if ('disabled' !== getenv('SYMFONY_DEPRECATIONS_HELPER')) { 
        
               DeprecationErrorHandler::register(getenv('SYMFONY_DEPRECATIONS_HELPER')); 
        
           }

?

greg0ire · 2019-06-08T10:40:01Z

Please resolve #31955 first

nicolas-grekas · 2019-06-08T13:29:09Z

I'd propose merging this as a bug fix on 4.3, which is the very of Dotenv that relates here, WDYT?

greg0ire · 2019-06-08T14:21:21Z

It can be viewed as a bug if you use the bridge v4.3 and a recent version of dotenv so yeah, let's do this :)

greg0ire · 2019-06-08T14:38:25Z

Done. What about my question about the bootstrap file above?

nicolas-grekas · 2019-06-08T14:55:11Z

Let's update the bootstrap file too.

greg0ire · 2019-06-08T15:14:38Z

I should really test before I push 😓

greg0ire · 2019-06-08T15:17:15Z

Apparently having the class not defined at all is a requirement in disabled mode, so let's do this.

greg0ire · 2019-06-08T15:26:54Z

Is setting via putenv kind of deprecated now? Or will it be fully supported forever? Should I change existing phpt files to randomly use each of them?

tgalopin · 2019-06-23T10:44:08Z

IMHO, this is quite important to finish and release as if I understand correctly, for now there is no way to configure the SYMFONY_DEPRECATIONS_HELPER variable except by using a real env var (quite cumbersome and the documentation is very misleading on this subject if that's true). Or am I missing something?

I'd be happy to give a hand to finish this if needed.

greg0ire · 2019-06-23T12:48:49Z

Thanks for proposing your help @tgalopin . To me, this could very well be finished already, the only doubts I have are sum up in my previous comment. @nicolas-grekas what do you think the next steps are regarding this?

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php

greg0ire · 2019-06-23T15:44:58Z

I do not reproduce the build failure locally (I use php 7.3). They are probably due to autoloading conflicts, as usual.

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php

fabpot · 2019-06-26T07:56:14Z

Can you have a look at the broken tests?

The Dotenv component has recently been switched to using superglobals instead of putenv(). Let us support both and give priority to superglobals. Closes symfony#31857

nicolas-grekas

I reverted the changes on bootstrap.php: Dotenv always runs after the file is executed so that they were not needed. I also simplified the code: false already does what we planned for null to do.
Tests will pass once this is merged up to master.

nicolas-grekas · 2019-06-26T09:24:28Z

Thank you @greg0ire.

…s (greg0ire) This PR was merged into the 4.3 branch. Discussion ---------- [PhpunitBridge] Read environment variable from superglobals | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31857 | License | MIT | Doc PR | n/a The Dotenv component has recently been switched to using superglobals instead of putenv(). Let us support both and give priority to superglobals. Commits ------- 88cfcb5 [PhpunitBridge] Read environment variable from superglobals

carsonbot added Status: Needs Review Feature labels Jun 8, 2019

greg0ire force-pushed the read-env-var-from-superglobals branch 2 times, most recently from 2a955f8 to afe721e Compare June 8, 2019 10:28

greg0ire changed the title ~~Read environment variable from superglobals~~ [PhpunitBridge] Read environment variable from superglobals Jun 8, 2019

greg0ire force-pushed the read-env-var-from-superglobals branch from afe721e to 0e832ca Compare June 8, 2019 14:26

greg0ire changed the base branch from 4.4 to 4.3 June 8, 2019 14:26

greg0ire force-pushed the read-env-var-from-superglobals branch from 0e832ca to e9971b5 Compare June 8, 2019 14:37

greg0ire force-pushed the read-env-var-from-superglobals branch from e9971b5 to 936cb7d Compare June 8, 2019 15:13

greg0ire force-pushed the read-env-var-from-superglobals branch 2 times, most recently from e7e3593 to 72cb77a Compare June 8, 2019 15:26

greg0ire force-pushed the read-env-var-from-superglobals branch from 72cb77a to 1fe6eb2 Compare June 9, 2019 19:56

greg0ire marked this pull request as ready for review June 10, 2019 07:58

nicolas-grekas added this to the 4.3 milestone Jun 11, 2019

nicolas-grekas added Bug and removed Feature labels Jun 11, 2019

nicolas-grekas reviewed Jun 23, 2019

View reviewed changes

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php Outdated Show resolved Hide resolved

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php Outdated Show resolved Hide resolved

greg0ire force-pushed the read-env-var-from-superglobals branch from 1fe6eb2 to 8dea1ee Compare June 23, 2019 15:20

nicolas-grekas reviewed Jun 23, 2019

View reviewed changes

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php Outdated Show resolved Hide resolved

greg0ire force-pushed the read-env-var-from-superglobals branch from 8dea1ee to 1bbfbc4 Compare June 23, 2019 15:50

carsonbot removed the Status: Needs Review label Jun 23, 2019

nicolas-grekas approved these changes Jun 23, 2019

View reviewed changes

carsonbot added the Status: Reviewed label Jun 23, 2019

fabpot approved these changes Jun 26, 2019

View reviewed changes

nicolas-grekas force-pushed the read-env-var-from-superglobals branch 2 times, most recently from be0ecf5 to 3945785 Compare June 26, 2019 09:16

[PhpunitBridge] Read environment variable from superglobals

88cfcb5

The Dotenv component has recently been switched to using superglobals instead of putenv(). Let us support both and give priority to superglobals. Closes symfony#31857

nicolas-grekas force-pushed the read-env-var-from-superglobals branch from 3945785 to 88cfcb5 Compare June 26, 2019 09:18

nicolas-grekas approved these changes Jun 26, 2019

View reviewed changes

nicolas-grekas merged commit 88cfcb5 into symfony:4.3 Jun 26, 2019

greg0ire deleted the read-env-var-from-superglobals branch June 26, 2019 09:43

xabbuh added the PhpUnitBridge label Jun 26, 2019

fabpot mentioned this pull request Jun 26, 2019

Release v4.3.2 #32195

Merged

Uh oh!

[PhpunitBridge] Read environment variable from superglobals #31954

[PhpunitBridge] Read environment variable from superglobals #31954

Uh oh!

Conversation

greg0ire commented Jun 8, 2019 • edited by nicolas-grekas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greg0ire commented Jun 8, 2019

Uh oh!

greg0ire commented Jun 8, 2019

Uh oh!

nicolas-grekas commented Jun 8, 2019

Uh oh!

greg0ire commented Jun 8, 2019

Uh oh!

greg0ire commented Jun 8, 2019

Uh oh!

nicolas-grekas commented Jun 8, 2019

Uh oh!

greg0ire commented Jun 8, 2019

Uh oh!

greg0ire commented Jun 8, 2019

Uh oh!

greg0ire commented Jun 8, 2019

Uh oh!

tgalopin commented Jun 23, 2019

Uh oh!

greg0ire commented Jun 23, 2019

Uh oh!

Uh oh!

Uh oh!

greg0ire commented Jun 23, 2019

Uh oh!

Uh oh!

fabpot commented Jun 26, 2019

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Jun 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

greg0ire commented Jun 8, 2019 •

edited by nicolas-grekas

Loading