Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not log or call the proxy function when the locale is the same #32014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Jun 12, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

I was the one creating the PR for logging the change of the locale but ATM I am filled with logs of translator about switching the locale from "en" to "en".. Not sure why.

@fabpot
Copy link
Member

fabpot commented Jun 13, 2019

Thank you @gmponos.

@fabpot fabpot merged commit 31bdfb3 into symfony:4.3 Jun 13, 2019
fabpot added a commit that referenced this pull request Jun 13, 2019
…he same (gmponos)

This PR was squashed before being merged into the 4.3 branch (closes #32014).

Discussion
----------

Do not log or call the proxy function when the locale is the same

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

I was the one creating the PR for logging the change of the locale but ATM I am filled with logs of translator about switching the locale from "en" to "en".. Not sure why.

Commits
-------

31bdfb3 Do not log or call the proxy function when the locale is the same
@gmponos gmponos deleted the patch-4 branch June 13, 2019 10:05
@fabpot fabpot mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants