Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Remove DispatchAfterCurrentBusStamp when message is put on internal queue #32027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2019
Merged

[Messenger] Remove DispatchAfterCurrentBusStamp when message is put on internal queue #32027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ final class QueuedEnvelope

public function __construct(Envelope $envelope, StackInterface $stack)
{
$this->envelope = $envelope;
$this->envelope = $envelope->withoutAll(DispatchAfterCurrentBusStamp::class);
$this->stack = $stack;
}

Expand Down
47 changes: 47 additions & 0 deletions src/Symfony/Component/Messenger/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,53 @@ public function testThrowingEventsHandlingWontStopExecution()
$messageBus->dispatch($message);
}

public function testHandleDelayedEventFromQueue()
{
$message = new DummyMessage('Hello');
$event = new DummyEvent('Event on queue');

$middleware = new DispatchAfterCurrentBusMiddleware();
$commandHandlingMiddleware = $this->createMock(MiddlewareInterface::class);
$eventHandlingMiddleware = $this->createMock(MiddlewareInterface::class);

// This bus simulates the bus that are used when messages come back form the queue
$messageBusAfterQueue = new MessageBus([
// Create a new middleware
new DispatchAfterCurrentBusMiddleware(),
$eventHandlingMiddleware,
]);

$fakePutMessageOnQueue = $this->createMock(MiddlewareInterface::class);
$fakePutMessageOnQueue->expects($this->any())
->method('handle')
->with($this->callback(function ($envelope) use ($messageBusAfterQueue) {
// Fake putting the message on the queue
// Fake reading the queue
// Now, we add the message back to a new bus.
$messageBusAfterQueue->dispatch($envelope);

return true;
}))
->willReturnArgument(0);

$eventBus = new MessageBus([
$middleware,
$fakePutMessageOnQueue,
]);

$messageBus = new MessageBus([
$middleware,
new DispatchingMiddleware($eventBus, [
new Envelope($event, [new DispatchAfterCurrentBusStamp()]),
]),
$commandHandlingMiddleware,
]);

$this->expectHandledMessage($commandHandlingMiddleware, 0, $message);
$this->expectHandledMessage($eventHandlingMiddleware, 0, $event);
$messageBus->dispatch($message);
}

/**
* @param MiddlewareInterface|MockObject $handlingMiddleware
*/
Expand Down