[HttpClient] throw DecodingExceptionInterface when toArray() fails because of content-type error #32065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause of content-type error
ro0NL
approved these changes
Jun 16, 2019
javiereguiluz
approved these changes
Jun 17, 2019
derrabus
approved these changes
Jun 17, 2019
chalasr
approved these changes
Jun 17, 2019
|
This changes the public API and involve code changes in userland though (and could be worth a CHANGELOG entry), which hints that this is a new feature to me. |
for experimental components, we can bypass this rule, because here this is also a BC break, and we should close any such issues asap. That's why I added "bug fix at the contracts level" in the description. |
fabpot
approved these changes
Jun 17, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 17, 2019
…() fails because of content-type error (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] throw DecodingExceptionInterface when toArray() fails because of content-type error | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31913 | License | MIT | Doc PR | - As spotted in the linked issue, we are missing this type of exception. It's a bug at the contracts level. Commits ------- 3f16741 [HttpClient] throw DecodingExceptionInterface when toArray() fails because of content-type error
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in the linked issue, we are missing this type of exception. It's a bug at the contracts level.