Don't assume port 0 for X-Forwarded-Port #32096
Conversation
|
Could you please add a test case? |
|
@nicolas-grekas I've added a test for this. |
|
Hmm, strange, its failing on the tests. But passes locally. I'll take a look at that this evening. |
|
I'm a little confused, it is failing on php 5.5, but is fine on php 7.0+. Nothing I changed should affect 5.5, any ideas? |
|
@alexbowers PHP changed how |
|
Ah, thank you @xabbuh |
|
Hmm, can AppVeyor be re-ran? I can't see any cause for it failing. |
| $request = Request::create('/'); | ||
| $request->server->set('REMOTE_ADDR', '1.1.1.1'); | ||
| $request->headers->set('X-Forwarded-Host', 'test.example.com'); | ||
| $request->headers->set('X-Forwarded-Port', null); |
There was a problem hiding this comment.
HeaderBag::set does not accept null. Maybe you meant to use an empty string.
|
Thank you @alexbowers. |
This PR was merged into the 3.4 branch. Discussion ---------- Don't assume port 0 for X-Forwarded-Port | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | none added | Fixed tickets | | License | MIT | Doc PR | - If you use X-Forwarded-Host but don't provide X-Forwarded-Port, it will default to `0.0.0.0:` which then assumes port `0` instead of following its default assumption based on the scheme. Commits ------- adcdd93 PHP 5 compat 6c49a0c Add test case c266d6c Update Request.php 23db9be Don't assume port 0 for X-Forwarded-Port
|
@fabpot any idea when the next release will be? |
If you use X-Forwarded-Host but don't provide X-Forwarded-Port, it will default to
0.0.0.0:which then assumes port0instead of following its default assumption based on the scheme.