Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] remove comment about to-be-removed method #32177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Jun 25, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#...

it is used in master by ButtonBuilder, see #32160 (comment)

@fabpot
Copy link
Member

fabpot commented Jun 26, 2019

Thank you @Tobion.

@fabpot fabpot merged commit b80ce9a into symfony:4.4 Jun 26, 2019
fabpot added a commit that referenced this pull request Jun 26, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] remove comment about to-be-removed method

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

it is used in master by ButtonBuilder, see #32160 (comment)

Commits
-------

b80ce9a [Form] remove comment about to-be-removed method as it is used in master by ButtonBuilder
@Tobion Tobion deleted the remove-comment-about-to-be-removed branch June 26, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants