Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[5.0] [Debug] Add parameter type-hints where possible #32217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removing redundant nullable
  • Loading branch information
Matthew Smeets committed Jul 17, 2019
commit c5756adf5ffab755cfd619fe938802636f9538fb
5 changes: 4 additions & 1 deletion src/Symfony/Component/Debug/DebugClassLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ public static function disable()
}
}

public function findFile(string $class = null)
/**
* @param string $class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. You must not remove the the doc for the return type (and adding the doc for the param is useless now, as it duplicates the typehint)

*/
public function findFile(string $class)
{
return $this->isFinder ? $this->classLoader[0]->findFile($class) ?: null : null;
}
Expand Down