[5.0][Filesystem] add parameter type hints #32247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b94651 to
c86fc51
Compare
derrabus
reviewed
Jun 28, 2019
|
|
57 tasks
c86fc51 to
3ec8897
Compare
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…l (smoench) This PR was merged into the 4.4 branch. Discussion ---------- [Filesystem] deprecate calling isAbsolutePath with a null | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This PR is a result of #32247 and deprecates calling `Filesystem::isAbsolutePath()` with a `null` value. Commits ------- 9319018 [Filesystem] depreacte calling isAbsolutePath with a null
fabpot
requested changes
Jul 5, 2019
3ec8897 to
8f68b9e
Compare
8f68b9e to
ba7dab6
Compare
|
Not needed phpdocs are removed |
fabpot
approved these changes
Jul 8, 2019
|
Thank you @smoench. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [5.0][Filesystem] add parameter type hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR adds parameter type hints to the Filesystem component. Commits ------- ba7dab6 [5.0][Filesystem] add parameter type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parameter type hints to the Filesystem component.