fix Debug component dependencies #32248
Conversation
xabbuh
commented
Jun 28, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -22,6 +22,7 @@ | |||
| "symfony/class-loader": "~3.2", | |||
| "symfony/dependency-injection": "^3.4.24|^4.2.5", | |||
| "symfony/config": "~3.4|~4.0", | |||
| "symfony/debug": "~2.8|~3.0|~4.0", | |||
There was a problem hiding this comment.
FrameworkBundle registers Symfony\Component\Debug\ErrorHandler when boot() is called
| @@ -18,6 +18,7 @@ | |||
| "require": { | |||
| "php": "^5.5.9|>=7.0.8", | |||
| "symfony/config": "~3.2|~4.0", | |||
| "symfony/debug": "~2.8|~3.0|~4.0", | |||
There was a problem hiding this comment.
ExceptionController::showAction() has a parameter of type Symfony\Component\Debug\Exception\FlattenException
|
Before #31065, the Debug component was installed as a transitive dependency. |
| @@ -61,7 +61,7 @@ public function testHandleClassNotFound($error, $translatedMessage, $autoloader | |||
| } | |||
|
|
|||
| $this->assertInstanceOf('Symfony\Component\Debug\Exception\ClassNotFoundException', $exception); | |||
| $this->assertSame($translatedMessage, $exception->getMessage()); | |||
| $this->assertRegExp($translatedMessage, $exception->getMessage()); | |||
There was a problem hiding this comment.
why switching this to a regex, while all your regexps are anchored on both sides and contain only static parts ?
There was a problem hiding this comment.
He added a .* in lines 103 and 121.
There was a problem hiding this comment.
error messages differ slightly for these two cases when the ErrorCatcher component is present: https://travis-ci.org/symfony/symfony/jobs/551399461#L4725
|
Thank you @xabbuh. |
This PR was merged into the 3.4 branch. Discussion ---------- fix Debug component dependencies | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 87fe077 fix Debug component dependencies