[Security] [Guard] Added type-hints to AuthenticatorInterface #32254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Jun 28, 2019
|
These classes contain a lot of useless |
|
Done here #32257 for 3.4 (@nicolas-grekas @derrabus) |
d02bbde to
f445329
Compare
fabpot
added a commit
that referenced
this pull request
Jun 30, 2019
…omasbisignani) This PR was merged into the 3.4 branch. Discussion ---------- [Security] [Guard] Removed useless param annotations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32254 (comment) | License | MIT | Doc PR | The PR removes useless `@param` annotation, it is linked with the #32254 (comment) Commits ------- 848e881 [Security] [Guard] Removed useless param annotations
|
Fixed. |
57 tasks
|
Rebase unlocked :) |
f445329 to
37dcff6
Compare
37dcff6 to
51b3c2e
Compare
|
Rebased. |
fabpot
approved these changes
Jul 3, 2019
|
Thank you @thomasbisignani. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…rface (thomasbisignani) This PR was merged into the 5.0-dev branch. Discussion ---------- [Security] [Guard] Added type-hints to AuthenticatorInterface | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | This PR adds the type-hints to the AuthenticatorInterface Commits ------- 51b3c2e [Security] [Guard] Added type-hints to AuthenticatorInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the type-hints to the AuthenticatorInterface