[Workflow] Deprecated DefinitionBuilder::setInitialPlace() #32258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I started reviewing this, but I'm not sure it's desired, the new name is not better when only one place exists - and code exists that would need to be upgraded, to a name that wouldn't fit well.
Since it's not obvious, it should maybe be for 4.4, if we still want to do it.
Everywhere else we are using We should merge it in 4.3 to avoid confusion |
nicolas-grekas
approved these changes
Jun 28, 2019
Added missing part of symfony#30468
lyrixx
added a commit
that referenced
this pull request
Jun 28, 2019
…() (lyrixx) This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] Deprecated DefinitionBuilder::setInitialPlace() Added missing part of #30468 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 4d002e8 [Workflow] Deprecated DefinitionBuilder::setInitialPlace()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing part of #30468