[Config] finish adding parameter types #32286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c8f52a to
cd07c1a
Compare
derrabus
requested changes
Jun 29, 2019
src/Symfony/Component/DependencyInjection/Config/ContainerParametersResourceChecker.php
Show resolved
Hide resolved
cd07c1a to
1905db9
Compare
1905db9 to
2ca8354
Compare
|
Fixed dependencies. This will happen anyway eventually with all the types added in master. |
Tobion
added a commit
that referenced
this pull request
Jul 2, 2019
…ion) This PR was merged into the 4.3 branch. Discussion ---------- fix invalid call to PhpFileLoader::load() in a test | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yno | New feature? | yno <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | This was calling `\Symfony\Component\DependencyInjection\Loader\PhpFileLoader::load($resource, string $type = null)` with the container object as $type which I found in #32286 Commits ------- 8930335 fix invalid call to PhpFileLoader::load() in a test
| @@ -417,6 +411,10 @@ protected function createNode() | |||
| } | |||
|
|
|||
| if ($this->default) { | |||
| if (!\is_array($this->defaultValue)) { | |||
There was a problem hiding this comment.
only for 5? missing deprecation in 4.4?
There was a problem hiding this comment.
I just moved the check from PrototypedArrayNode.php::setDefaultValue here so the typhint in setDefaultValue can be added. The $this->defaultValue comes from a generic setter that we cannot use types for. The behavior is the same, just cleaner code using types when possible.
I can do it for the single |
Closed
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Fix phpdocs | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Backported from #32286 <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 4acddef fixed phpdocs
fabpot
approved these changes
Jul 5, 2019
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Config] finish adding parameter types | Q | A | ------------- | --- | Branch? | master | Bug fix? | yno | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Completes some missing things in #32201 Commits ------- 2ca8354 [Config] finish adding parameter types
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes some missing things in #32201