[Cache] finish type-hints #32298
Merged
[Cache] finish type-hints #32298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Jul 1, 2019
| @@ -53,7 +53,7 @@ public function __construct(string $namespace = '', int $defaultLifetime = 0, st | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| protected function doSave(array $values, ?int $lifetime, array $addTagData = [], array $removeTagData = []): array | |||
| protected function doSave(array $values, int $lifetime, array $addTagData = [], array $removeTagData = []): array | |||
There was a problem hiding this comment.
The parent has an int $lifetime and it does not seem to ever be called with null as lifetime. Also current implementation would be broken with null because two lines below it calls $this->doSaveCache($values, $lifetime); which requires an int as lifetime.
nicolas-grekas
approved these changes
Jul 1, 2019
Simperfit
approved these changes
Jul 1, 2019
Tobion
added a commit
that referenced
this pull request
Jul 2, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Cache] finish type-hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Finish leftovers from #32282 Commits ------- 1919c7d [Cache] finish type-hints
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish leftovers from #32282