[Filesystem] deprecate calling isAbsolutePath with a null #32315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f39772 to
71d93f9
Compare
71d93f9 to
6852d51
Compare
derrabus
approved these changes
Jul 2, 2019
6852d51 to
da924ab
Compare
xabbuh
reviewed
Jul 2, 2019
|
I did not add them because the deprecations of dumpFile and appendFile are not documented in UPGRADE-4.3.md. I will add them and provide an PR for the missing ones |
da924ab to
9319018
Compare
|
|
xabbuh
approved these changes
Jul 3, 2019
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…d (smoench) This PR was merged into the 4.3 branch. Discussion ---------- [Filesystem] added missing deprecations to UPGRADE-4.3.md | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | no needed This PR is a result of #32315 and adds missing deprecations to UPGRADE-4.3.md. Commits ------- b5c6a34 [Filesystem] added missing deprecations to UPGRADE-4.3.md
fabpot
approved these changes
Jul 3, 2019
|
Thank you @smoench. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…l (smoench) This PR was merged into the 4.4 branch. Discussion ---------- [Filesystem] deprecate calling isAbsolutePath with a null | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This PR is a result of #32247 and deprecates calling `Filesystem::isAbsolutePath()` with a `null` value. Commits ------- 9319018 [Filesystem] depreacte calling isAbsolutePath with a null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of #32247 and deprecates calling
Filesystem::isAbsolutePath()with anullvalue.