[FrameworkBundle] Simplified some code in the DI configuration #32322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Jul 2, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | not needed |
stof
approved these changes
Jul 3, 2019
fabpot
approved these changes
Jul 3, 2019
|
Will merge in 4.4 as this is not a bug fix. |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…ration (javiereguiluz) This PR was submitted for the 3.4 branch but it was merged into the 4.4 branch instead (closes #32322). Discussion ---------- [FrameworkBundle] Simplified some code in the DI configuration | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | not needed Commits ------- e6d76ba [FrameworkBundle] Simplified some code in the DI configuration
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…ration (javiereguiluz) This PR was merged into the 4.3 branch. Discussion ---------- [FrmaeworkBundle] More simplifications in the DI configuration | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | not needed This is the continuation of #32322 for the 4.3 branch. Commits ------- fa6ae8c [FrmaeworkBundle] More simplifications in the DI configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.