[DI] Move non removing compiler passes to after removing passes #32332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but there are related failing test cases, could you please have a look? |
ea0f681 to
88196ef
Compare
nicolas-grekas
approved these changes
Jul 18, 2019
|
@nicolas-grekas thank you! This slipped from my radar! |
fabpot
approved these changes
Jul 18, 2019
|
Thank you @alexpott. |
fabpot
added a commit
that referenced
this pull request
Jul 18, 2019
…ng passes (alexpott) This PR was merged into the 4.4 branch. Discussion ---------- [DI] Move non removing compiler passes to after removing passes | Q | A | ------------- | --- | Branch? | Not sure - feels like something that should only change in a major version but /shrug | Bug fix? | no | New feature? | no | BC breaks? | Is where each pass runs in PassConfig considered an API - not sure. | Deprecations? | no | Tests pass? | yes - no tests added because this is a sort of config change | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> At the moment PassConfig adds CheckExceptionOnInvalidReferenceBehaviorPass and ResolveHotPathPass as TYPE_REMOVE. But they don't remove services. This means that if you add a removing pass you need to run before all the other removing passes. You can use priority to do this but I think adding these passes here is logically a bit odd when TYPE_AFTER_REMOVING exists and could be leveraged. I made this change against the master branch because maybe this is something you'd only want to change in a major version - not sure. Commits ------- 88196ef [DI] Move non removing compiler passes to after removing passes
This was referenced Jul 19, 2019
Merged
This was referenced Nov 12, 2019
Merged
Merged
mhujer
added a commit
to mhujer/SymfonyDependencyInjectionTest
that referenced
this pull request
Nov 24, 2019
This is necessary because symfony/symfony#32332 configures some
|
@alexpott looks like this was indeed a BC-break, see https://travis-ci.org/sonata-project/SonataCoreBundle/jobs/617863917#L572-L590 |
|
@greg0ire it should be fixed in SymfonyTest/SymfonyDependencyInjectionTest#125 |
Nyholm
pushed a commit
to SymfonyTest/SymfonyDependencyInjectionTest
that referenced
this pull request
Dec 3, 2019
) This is necessary because symfony/symfony#32332 configures some
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment PassConfig adds CheckExceptionOnInvalidReferenceBehaviorPass and ResolveHotPathPass as TYPE_REMOVE. But they don't remove services. This means that if you add a removing pass you need to run before all the other removing passes. You can use priority to do this but I think adding these passes here is logically a bit odd when TYPE_AFTER_REMOVING exists and could be leveraged.
I made this change against the master branch because maybe this is something you'd only want to change in a major version - not sure.