[Messenger] fix broken key normalization #32380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 5, 2019
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] fix broken key normalization | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Disable broken key normalization in messenger config. If you tried to use `-` in a transport/bus it didn't work and you get a cryptic error (#31613) ``` framework: messenger: transports: my-bus: '...' routing: Acme\MyMessage: my-bus ``` The default behavior of normalizing keys is really annoying and a waste of time in most cases. I've measured `\Symfony\Component\Config\Definition\ArrayNode::preNormalize` in a project and it takes 4 ms. As an idea, we could disabling normalizing keys automatically when you call `useAttributeAsKey` because the value is then user-provided and shouldn't be modified (in contrast to children properties of an arrayNode which should get normalized for xml support). Commits ------- 9931b3e [Messenger] fix broken key normalization
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable broken key normalization in messenger config.
If you tried to use
-in a transport/bus it didn't work and you get a cryptic error (#31613)The default behavior of normalizing keys is really annoying and a waste of time in most cases. I've measured
\Symfony\Component\Config\Definition\ArrayNode::preNormalizein a project and it takes 4 ms.As an idea, we could disabling normalizing keys automatically when you call
useAttributeAsKeybecause the value is then user-provided and shouldn't be modified (in contrast to children properties of an arrayNode which should get normalized for xml support).