-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] AbstractObjectNormalizer ignores the property types of discriminated classes #32383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you please add a test case? |
@nicolas-grekas Added a test case ;) |
nicolas-grekas
approved these changes
Jul 8, 2019
…discriminated classes Add tests Remove test group Allow null Add quux null attribute Add quux value to serialize test
@sandergo90 I let you ping me when tests pass so that I can merge. |
@fabpot done ! |
fabpot
approved these changes
Jul 8, 2019
Thank you @sandergo90. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
… types of discriminated classes (sandergo90) This PR was merged into the 4.2 branch. Discussion ---------- [Serializer] AbstractObjectNormalizer ignores the property types of discriminated classes | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27607 | License | MIT | Doc PR | As discusses in ticket #27607, when using a discriminator map and the symfony serializer, things go wrong when having two classes in the discriminator map having the same property name. When the function ```validateAndDenormalize``` is called, the function ```getTypes``` would be called with the wrong class name. If you take a look at the ```getTypes``` function below, I'm not even sure if we still need the part of the discriminator at this place because we already passed the class name of the discriminated class. ``` /** * @return Type[]|null */ private function getTypes(string $currentClass, string $attribute) { if (null === $this->propertyTypeExtractor) { return null; } if (null !== $types = $this->propertyTypeExtractor->getTypes($currentClass, $attribute)) { return $types; } if (null !== $this->classDiscriminatorResolver && null !== $discriminatorMapping = $this->classDiscriminatorResolver->getMappingForClass($currentClass)) { if ($discriminatorMapping->getTypeProperty() === $attribute) { return [ new Type(Type::BUILTIN_TYPE_STRING), ]; } foreach ($discriminatorMapping->getTypesMapping() as $mappedClass) { if (null !== $types = $this->propertyTypeExtractor->getTypes($mappedClass, $attribute)) { return $types; } } } return null; } ``` Commits ------- 9fc56c7 [Serializer]: AbstractObjectNormalizer ignores the property types of discriminated classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discusses in ticket #27607, when using a discriminator map and the symfony serializer, things go wrong when having two classes in the discriminator map having the same property name. When the function
validateAndDenormalize
is called, the functiongetTypes
would be called with the wrong class name.If you take a look at the
getTypes
function below, I'm not even sure if we still need the part of the discriminator at this place because we already passed the class name of the discriminated class.