[DependencyInjection] Added tests to cover the possibility of having scalars as services #32432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Jul 8, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32411 |
| License | MIT |
| Doc PR | N/A |
fabpot
requested changes
Jul 8, 2019
|
Can you add a test case that involves a dumped container please? |
ba81df3 to
60939d9
Compare
|
Done. |
|
Status: Needs Review |
|
Travis failures are unrelated. |
fabpot
approved these changes
Jul 9, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jul 9, 2019
…ty of having scalars as services (derrabus) This PR was merged into the 3.4 branch. Discussion ---------- [DependencyInjection] Added tests to cover the possibility of having scalars as services | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32411 | License | MIT | Doc PR | N/A Commits ------- 60939d9 Added tests to cover the possibility of having scalars as services.
nicolas-grekas
added a commit
that referenced
this pull request
Aug 13, 2019
…s-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] deprecate support for non-object services | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32411 | License | MIT | Doc PR | - Follows #32432 /cc @derrabus Prepares for adding the `?object` return-type on master. Commits ------- 7c01c4c [DI] deprecate support for non-object services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.