[Messenger] DispatchAfterCurrentBusMiddleware does not cancel messages from delayed handlers #32497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94ccb43 to
1f5c8a6
Compare
maidmaid
approved these changes
Jul 11, 2019
|
Wdyt @Nyholm? |
sroze
approved these changes
Aug 18, 2019
|
Thank you @BastienClement. |
fabpot
added a commit
that referenced
this pull request
Aug 18, 2019
…cel messages from delayed handlers (Nyholm, BastienClement) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] DispatchAfterCurrentBusMiddleware does not cancel messages from delayed handlers | Q | A | ------------- | --- | Branch? | 4.3 for bug fixes | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes (thanks @Nyholm) | Fixed tickets | #32370 | License | MIT | Doc PR | - This is a fix for #32370. There is no need for anything sophisticated. There is no recursion or fancy stuff going on, just a queue of message handled sequentially. A simple variable is enough to keep track of the queue state. Thanks @Nyholm for the test, it would clearly have been the hardest part of the job. Commits ------- 1f5c8a6 Cancel delayed message if handler fails 35c76a3 Added tests for #32370
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #32370. There is no need for anything sophisticated. There is no recursion or fancy stuff going on, just a queue of message handled sequentially. A simple variable is enough to keep track of the queue state.
Thanks @Nyholm for the test, it would clearly have been the hardest part of the job.