fix some deprecations and add upgrade instructions #32533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 13, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
Tobion
approved these changes
Jul 13, 2019
Simperfit
reviewed
Jul 14, 2019
| @@ -74,7 +74,7 @@ public function save(Key $key) | |||
| */ | |||
| public function waitAndSave(Key $key) | |||
| { | |||
| @trigger_error(sprintf('%s has been deprecated since Symfony 4.4 and will be removed in Symfony 5.0.', __METHOD__)); | |||
| @trigger_error(sprintf('%s() is deprecated since Symfony 4.4 and will be removed in Symfony 5.0.', __METHOD__)); | |||
There was a problem hiding this comment.
I have updated all of this in a PR already ;)
There was a problem hiding this comment.
I must have missed that one. :) So I am gonna rebase here afterwards.
Simperfit
approved these changes
Jul 14, 2019
fabpot
approved these changes
Jul 15, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 15, 2019
This PR was merged into the 4.4 branch. Discussion ---------- fix some deprecations and add upgrade instructions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- fa317f2 fix some deprecations and add upgrade instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.