Properly handle optional tag attributes for !tagged_iterator #32604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jul 18, 2019
|
(tests fail) |
When using the array syntax
|
@nicolas-grekas I wrote the test apparently for Symfony 4.4+, not 4.2. Should I send a separate PR for 4.4+, where I just rename |
|
Should it be merged in 4.2 or 4.3? |
|
Thank you @apfelbox. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 18, 2019
…or (apfelbox) This PR was merged into the 4.3 branch. Discussion ---------- Properly handle optional tag attributes for !tagged_iterator | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32603 | License | MIT | Doc PR | — Properly handles all optional array keys when using `!tagged_iterator` in YAML service definitions. This fixes a regression and adds a test case preventing it from coming up again Commits ------- d1c6580 Properly handle optional tag attributes for !tagged_iterator
|
@nicolas-grekas should I prepare a follow up PR for 4.4, or will you fix the test when merging up? |
|
It's already merged up :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handles all optional array keys when using
!tagged_iteratorin YAML service definitions.This fixes a regression and adds a test case preventing it from coming up again