[Mailer][DX] Improve exception message for unsupported scheme #32608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 19, 2019
fabpot
requested changes
Jul 19, 2019
src/Symfony/Component/Mailer/Exception/UnsupportedSchemeException.php
Outdated
Show resolved
Hide resolved
f900e94 to
8c24a53
Compare
|
Status: needs review |
fabpot
approved these changes
Jul 22, 2019
|
Thank you @Koc. |
fabpot
added a commit
that referenced
this pull request
Jul 22, 2019
…cheme (Koc) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer][DX] Improve exception message for unsupported scheme | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | waiting for Travis | Fixed tickets | - | License | MIT | Doc PR | - This PR improves exception message for unsupported schemes by providing list of available. Throw something like: ` 'The "foo" scheme is not supported for mailer "mailgun". Supported schemes are: "api", "http", "smtp".'` Commits ------- 8c24a53 [Mailer][DX] Improve exception message for unsupported scheme
fabpot
added a commit
that referenced
this pull request
Jul 25, 2019
…es (Koc) This PR was squashed before being merged into the 4.4 branch (closes #32609). Discussion ---------- [Mailer][DX][RFC] Rename mailer bridge transport classes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yno | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - During working on #31946 I realized how painful to work with multiple classes which has same name. [Nice article](https://www.tomasvotruba.cz/blog/2019/05/02/alias-as-a-code-smell/) by @TomasVotruba with explanation of problems with such approach. ~Built on top of #32608 , so only [2nd commit](bbf7e99) is actual.~ Also I've changed namespaces to make bridge structure much simpler and be linear. All classes located on same level now. See how [bridge](https://github.com/symfony/symfony/tree/bbf7e99e89c70fab372929827ae509b41280ce40/src/Symfony/Component/Mailer/Bridge/Amazon) looks like now. Now in RFC state to get approve for such king of changes and update all other bridges. Commits ------- eda4f01 [Mailer][DX][RFC] Rename mailer bridge transport classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves exception message for unsupported schemes by providing list of available. Throw something like:
'The "foo" scheme is not supported for mailer "mailgun". Supported schemes are: "api", "http", "smtp".'