[ErrorHandler][HttpKernel] Removed ExceptionHandler class, use ErrorHandler instead #32636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $caughtLength = $this->caughtLength = 0; | ||
|
|
||
| ob_start(function ($buffer) { |
There was a problem hiding this comment.
this logic is not needed anymore, because we use the very same renderer with or without Symony fullstack, right?
| } | ||
|
|
||
| if (!headers_sent()) { | ||
| header(sprintf('HTTP/1.0 %s', $exception->getStatusCode())); |
There was a problem hiding this comment.
Do we have an equivalent logic in the error-render component?
| if (null !== $this->fileLinkFormat) { | ||
| $handler->setFileLinkFormat($this->fileLinkFormat); | ||
| } | ||
| $handler->setExceptionHandler($this->exceptionHandler); |
There was a problem hiding this comment.
shouldn't be $this->exceptionHandler be used instead of $this->errorRenderer below, and decouple the rendering using proper DI?
730969c to
80c760b
Compare
fabpot
added a commit
that referenced
this pull request
Jul 25, 2019
…yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32637). Discussion ---------- [ErrorHandler] Decouple from ErrorRenderer component | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | part of #32605 | License | MIT | Doc PR | - built on top of #32636 (See 2nd commit only) Commits ------- 8f13fc0 [ErrorHandler] Decouple from ErrorRenderer component
|
I'm closing here since #32637 was merged. @nicolas-grekas I've added all your comments to my TODO list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExceptionHandler's job "converting an exception to a Response object" is now handled by DebugHandlersListener + ErrorRenderer.