[Messenger] Retrieve table default options from the SchemaManager #32641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Jul 20, 2019
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
baeeadd to
b1c2e56
Compare
Tobion
reviewed
Jul 21, 2019
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
58843f3 to
0dbfc31
Compare
Tobion
reviewed
Jul 26, 2019
src/Symfony/Component/Messenger/Tests/Transport/Doctrine/DoctrineTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
Tobion
reviewed
Jul 26, 2019
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
0dbfc31 to
301ceae
Compare
Tobion
approved these changes
Jul 28, 2019
1660f8d to
93d0dc8
Compare
|
Thank you @vincenttouzet. |
Tobion
added a commit
that referenced
this pull request
Jul 28, 2019
…Manager (vincenttouzet) This PR was squashed before being merged into the 4.3 branch (closes #32641). Discussion ---------- [Messenger] Retrieve table default options from the SchemaManager | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32321 <!-- #-prefixed issue number(s), if any --> | License | MIT This PR modify the Connection of the Doctrine Transport. It is now possible to specify a `SchemaConfig` that will be used when generating tables. If Doctrine is configured as the following : ```yml # config/packages/doctrine.yaml doctrine: dbal: default_table_options: charset: 'utf8mb4' collate: 'utf8mb4_unicode_ci' ``` Then those options are used to create the table. ping @weaverryan 😉 Commits ------- 93d0dc8 [Messenger] Retrieve table default options from the SchemaManager
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modify the Connection of the Doctrine Transport. It is now possible to specify a
SchemaConfigthat will be used when generating tables.If Doctrine is configured as the following :
Then those options are used to create the table.
ping @weaverryan 😉