[Tests] Replace setUp()/tearDown() with before()/after()
#32651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be done on 3.4 actually |
|
Target branch was updated to |
|
What does it say on PHP 7.4? Maybe we should merge both PR to check, and because they are related? |
src/Symfony/Bridge/Doctrine/Tests/ContainerAwareEventManagerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/Doctrine/Tests/DependencyInjection/DoctrineExtensionTest.php
Outdated
Show resolved
Hide resolved
|
Can you please have a look at tests? (and maybe rebase to be sure you have the latest changes) |
|
I tried to make this green, but it looks like it's almost impossible using this strategy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
parent::setUp()andparent::tearDown()where required.See #32289 (comment).