[Intl] relax some date parser patterns #32679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jul 23, 2019
| @@ -548,8 +548,12 @@ public function testGetTimeType() | |||
| /** | |||
| * @dataProvider parseProvider | |||
| */ | |||
| public function testParse($pattern, $value, $expected) | |||
| public function testParse($pattern, $value, $expected, $requires64bit = false) | |||
c8cf1af to
4dbc735
Compare
stof
approved these changes
Jul 23, 2019
4dbc735 to
ebb43de
Compare
ebb43de to
7d0793a
Compare
|
Looks like PHP's |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] relax some date parser patterns | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While debugging the failures in #31374 I realised that the `IntlDateFormatter` from the Intl component parses dates more strictly than PHP's `IntlDateFormatter` class does. Commits ------- 7d0793a relax some date parser patterns
This was referenced Jul 27, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the failures in #31374 I realised that the
IntlDateFormatterfrom the Intl component parses dates more strictly than PHP'sIntlDateFormatterclass does.