[Messenger][Profiler] Collect the stamps at the end of dispatch #32680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Jul 24, 2019
…traceable middleware (ogizanagi) This PR was merged into the 4.2 branch. Discussion ---------- [Messenger] Flatten collection of stamps collected by the traceable middleware | Q | A | ------------- | --- | Branch? | 4.2 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A ### before   ### after  Not sure how it qualifies, but I assume this wasn't entirely intentional when introducing the new `Envelope::all()` behavior in #29159. Note it'll affect #32680 as well once merged. Commits ------- 015fca7 [Messenger] Flatten collection of stamps collected by the traceable middleware
nicolas-grekas
approved these changes
Jul 24, 2019
fabpot
approved these changes
Jul 27, 2019
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jul 27, 2019
… dispatch (ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger][Profiler] Collect the stamps at the end of dispatch | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Currently, only the stamps added before dispatching the message are shown in the profiler. This PR adds a section to show stamps after dispatch (`HandledStamp`, `SentStamp`, ...).  Commits ------- ee68b1d [Messenger][Profiler] Collect the stamps at the end of dispatch
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the stamps added before dispatching the message are shown in the profiler.
This PR adds a section to show stamps after dispatch (
HandledStamp,SentStamp, ...).