[HttpFoundation] Revert getClientIp @return docblock #32682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9b5ca0 to
7568d34
Compare
|
I just tried running this and it returned $r = new Request();
var_dump($r->getClientIp()); |
|
I think the docblock contains a type that must be, but not one that can be. |
|
No, docblock must specify type it returns |
|
But now it is not so, we must be consistent. If we want the docblock to contain what the method returns, we need to add |
nicolas-grekas
approved these changes
Jul 30, 2019
fabpot
approved these changes
Aug 4, 2019
|
Thank you @ossinkine. |
fabpot
added a commit
that referenced
this pull request
Aug 4, 2019
…nkine) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Revert getClientIp @return docblock | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> This PR reverts #22418, see the comment #22418 (comment) Commits ------- 7568d34 [HttpFoundation] Revert getClientIp @return docblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #22418, see the comment #22418 (comment)